Put #[automatically_derived] on impls#44
Merged
siefkenj merged 1 commit intosiefkenj:mainfrom Aug 30, 2024
BlueGreenMagick:snake-case-lint-error
Merged
Put #[automatically_derived] on impls#44siefkenj merged 1 commit intosiefkenj:mainfrom BlueGreenMagick:snake-case-lint-error
siefkenj merged 1 commit intosiefkenj:mainfrom
BlueGreenMagick:snake-case-lint-error
Conversation
they work on impls only, not blocks
Owner
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[automatically_derived]works only on impls, not blocks. This PR attaches the attribute on all generated impls.See: https://doc.rust-lang.org/reference/attributes/derive.html#the-automatically_derived-attribute
rust-lang/rust#120185
I was investigating madonoharu#42, and the issue turned out to be
#[automatically_derived]attributes being used on blocks that contains the impls, when it has to be used on the impls itself.Although that issue turned out to be from wasm-bindgen crate (already fixed, but not yet published in wasm-bindgen/wasm-bindgen#4078), I thought I would fix the same problems on this repo too.